Flysystem v3.0 #401
Open
Flysystem v3.0 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Connection.php to use the FtpConnectionOptions Object instead of an options array - Updated PHPloy.php to use the new directoryExists() function and updated exceptions - Made the unit tests work by including the share directory in the docker containers (dir was not found)
…les in sub directories and for deleting directories
|
Tested and so far seems to be working on both SFTP and FTP. |
|
Thank you @desm-it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated Flysystem to ^3.0 and adapted the code to work with the flysystem changes.
Also contains changes from sumpygump/PHPloy for flyststem-sftp
PHPUnit 8.5.33 by Sebastian Bergmann and contributors.
................. 17 / 17 (100%)
Time: 14.38 seconds, Memory: 6.00 MB
OK (17 tests, 64 assertions)